Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for class and tabindex attributes #31

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Add support for class and tabindex attributes #31

merged 2 commits into from
Sep 11, 2021

Conversation

larshanskrause
Copy link
Contributor

This pull request adds support to the class (as requested in enhancement #23) and tabindex attributes.

jcsmorais
jcsmorais approved these changes Sep 11, 2021
View reviewed changes
Copy link
Owner

@jcsmorais jcsmorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @larshanskrause 👍

@jcsmorais jcsmorais merged commit ba795ce into jcsmorais:master Sep 11, 2021
@jcsmorais jcsmorais mentioned this pull request Sep 11, 2021
Closed
@larshanskrause larshanskrause deleted the develop branch September 12, 2021 11:11
@hracik
Copy link
Contributor

hracik commented Nov 11, 2021

@jcsmorais
Hello, could you please make this a version so it can be used via npm, yarn.. current version 0.3.1 does not have this code.

@larshanskrause
Copy link
Contributor Author

I would very much appreciate a new npm version with this in it, too :)

@AaronPlave AaronPlave mentioned this pull request Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsmorais jcsmorais jcsmorais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larshanskrause @hracik @jcsmorais