Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #51: Writing Unit Test on Account Creation POST request #70

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Issue #51: Writing Unit Test on Account Creation POST request #70

merged 3 commits into from
Feb 19, 2021

Conversation

jcsnorlax97
Copy link
Owner

@jcsnorlax97 jcsnorlax97 commented Feb 17, 2021 •
edited
Loading

Associated Issues:

Description

Since another PR has completed the implementation of the POST request already, this PR only aims to add unit testing for the createUser() method in the /server/services folder, which is used within this POST request.

Main References

Output Screenshot

  • Results (After):
    Screen Shot 2021-02-16 at 7 37 41 PM

Time spent

  • 1h

Github action

Closes #51

@jcsnorlax97 jcsnorlax97 added backend Backend related tasks database Database related tasks Dev-task labels Feb 17, 2021
@jcsnorlax97 jcsnorlax97 added this to the Sprint 2 milestone Feb 17, 2021
@jcsnorlax97 jcsnorlax97 self-assigned this Feb 17, 2021
@jcsnorlax97 jcsnorlax97 added this to Under Review in Rentr via automation Feb 17, 2021
@jcsnorlax97 jcsnorlax97 linked an issue Feb 17, 2021 that may be closed by this pull request
[TASK] Story #35: POST Route for Account Creation #51
Closed
@jcsnorlax97 jcsnorlax97 changed the title Issue #51: Backend Implementation on Account Creation POST request Issue #51: Writing Unit Test on Account Creation POST request Feb 17, 2021
Rentr automation moved this from Under Review to Review Approved Feb 19, 2021
@RonnieDsouza RonnieDsouza merged commit 5919660 into develop Feb 19, 2021
Rentr automation moved this from Review Approved to Done Feb 19, 2021
@jcsnorlax97 jcsnorlax97 mentioned this pull request Feb 26, 2021
Closed
2 tasks
@jcsnorlax97 jcsnorlax97 added the High Priority Task with high priority label Feb 26, 2021
@jcsnorlax97 jcsnorlax97 deleted the Issue51-Task-TestingUserCreation branch February 27, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnieDsouza RonnieDsouza RonnieDsouza approved these changes

@Mik3Qiao Mik3Qiao Mik3Qiao approved these changes

@NathanCarriere NathanCarriere NathanCarriere approved these changes

@AzizulHakim96 AzizulHakim96 AzizulHakim96 approved these changes

Assignees

@jcsnorlax97 jcsnorlax97

Labels
backend Backend related tasks database Database related tasks Dev-task High Priority Task with high priority
Projects
Rentr
Done
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.

[TASK] Story #35: POST Route for Account Creation
5 participants
@jcsnorlax97 @RonnieDsouza @Mik3Qiao @NathanCarriere @AzizulHakim96