Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #71: Write Unit Test for getUser in UserService #92

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

jcsnorlax97
Copy link
Owner

Associated Issues:

Description

Previous PR (#72) does not have unit testing. This PR aims to add unit test for that. As another PR (#91) has not been merged to develop yet, this also delete the unused dao/user.test.js to ensure all testing pass.

Main References

  • N/A

Output Screenshot

  • Test Results:
    Screen Shot 2021-02-24 at 5 40 36 PM

Time spent

  • 1h

Github action

close #71

@jcsnorlax97 jcsnorlax97 added backend Backend related tasks database Database related tasks testing testing related tasks Dev-task labels Feb 24, 2021
@jcsnorlax97 jcsnorlax97 added this to the Sprint 2 milestone Feb 24, 2021
@jcsnorlax97 jcsnorlax97 self-assigned this Feb 24, 2021
@jcsnorlax97 jcsnorlax97 added this to Under Review in Rentr via automation Feb 24, 2021
Rentr automation moved this from Under Review to Review Approved Feb 25, 2021
@jcsnorlax97 jcsnorlax97 merged commit 0d974bb into develop Feb 25, 2021
Rentr automation moved this from Review Approved to Done Feb 25, 2021
@jcsnorlax97 jcsnorlax97 deleted the Issue71-JC-UnitTestForGetSingleUser branch February 25, 2021 06:04
@jcsnorlax97 jcsnorlax97 added the High Priority Task with high priority label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related tasks database Database related tasks Dev-task High Priority Task with high priority testing testing related tasks
Projects
Rentr
Done
4 participants