-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting automation items leaves items in other envelopes selected, count is reported incorrectly when deleting #1029
Labels
p1
High priority.
Comments
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…those in the current envelope, since the actions operate across envelopes. (#1029)
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…, unselect all automation items, not just those in the current envelope. (#1029) This is important because automation item selection doesn't get cleared when switching envelopes and some actions (including removal) operate across envelopes.
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…those in the current envelope, since the actions operate across envelopes. (#1029)
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…, unselect all automation items, not just those in the current envelope. (#1029) This is important because automation item selection doesn't get cleared when switching envelopes and some actions (including removal) operate across envelopes.
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…those in the current envelope, since the actions operate across envelopes. (#1029)
jcsteh
added a commit
that referenced
this issue
Mar 16, 2024
…, unselect all automation items, not just those in the current envelope. (#1029) This is important because automation item selection doesn't get cleared when switching envelopes and some actions (including removal) operate across envelopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spun off #394 (comment).
I always assumed automation item selection was only relevant for the currently selected envelope. This is true for points; e.g. if you select some points on a volume envelope and then select some points on a pan envelope, deleting points only deletes the points on the pan envelope.
It turns out that when you select an automation item, just like media items, it stays selected even if you switch envelopes. That means if you move to an automation item on a volume envelope and then move to an automation item on a pan envelope, pressing delete will actually delete both of them, even though we only report that one of them was deleted. Big ouch.
I'm going to need to fix this at a deeper level before I tackle splitting, etc. because otherwise, we're going to incorrectly select multiple items and incorrectly report how many are being manipulated, furthering the problem we already have for deletion.
The text was updated successfully, but these errors were encountered: