Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded splitters covering entire contents won't work #56

Closed
PandaWood opened this issue Jul 9, 2016 · 6 comments
Closed

Embedded splitters covering entire contents won't work #56

PandaWood opened this issue Jul 9, 2016 · 6 comments

Comments

@PandaWood
Copy link

PandaWood commented Jul 9, 2016

Hi, I've created a JSFiddle with a skeleton of the page I'm trying to do.
It has a horizontal splitter inside the right pane of a vertical splitter.

But the horizontal splitter just doesn't work - the dividing bar won't move and when the vertical pane is resized the horizontal splitter bounces back to a height of 0 and basically goes ballistic.

https://jsfiddle.net/o0tnchuy/7/

Is there an expectation of the html structure I'm missing?

I would really like to set the bottom horizontal pane to a set/fixed height, but it looks this library only uses the position property to set the top/left?

@jcubic
Copy link
Owner

jcubic commented Jul 9, 2016

It seems that you can nest divs inside right panel.

https://jsfiddle.net/o0tnchuy/8/

I need to investigate little bit more why is this happening.

@jcubic jcubic closed this as completed in 76780a2 Jul 9, 2016
@jcubic
Copy link
Owner

jcubic commented Jul 9, 2016

It was the same issue as #54 you need to set the height of the splitter in pixels I've fixed that in version 0.23.0.

@PandaWood
Copy link
Author

Yes, you're right. Thanks for that, sorry I didn't pick up on it. 0.23.0 is working for this now.

@jcubic
Copy link
Owner

jcubic commented Sep 6, 2016

Just found that in order to have 100% height the parent need to have defined height so this fixed the issue (even in old version):

#horizontal-body, #container, #content, body, html {
  height: 100%;
}

and you don't need $(window).resize https://jsfiddle.net/o0tnchuy/9/

@jcubic
Copy link
Owner

jcubic commented Sep 6, 2016

but you also need:

body {
  margin: 0;
}

otherwise you will have scrollbars.

@jcubic
Copy link
Owner

jcubic commented Nov 21, 2020

This is very old, but this solution in the code need to be removed. The proper fix is to have in user code:

#horizontal-body, #content {
  height: 100%;
}

the code that was used was not very good because the parents may be in different height and it also break #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants