Skip to content

Commit

Permalink
fix resize of the terminal with long prompt #919
Browse files Browse the repository at this point in the history
The problem was that cmd was resized and overflowed then
it was refreshed with new number of columns. This was causing
visible empty lines caused by style of ::before pseudo selector
before the each line (.cmd-line).
  • Loading branch information
jcubic committed Apr 7, 2024
1 parent c189b81 commit ddf9107
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.39.4
### Bugfix
* fix init and resize of long prompt [#919](https://github.com/jcubic/jquery.terminal/issues/919)

## 2.39.3
### Bugfix
* fix broken full screen terminal height on Desktop
Expand Down
4 changes: 4 additions & 0 deletions css/jquery.terminal-src.css
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
scrollbar-gutter: stable;
height: 100%;
box-sizing: border-box;
overflow-x: hidden;
}
terminal.terminal-temp {
visibility: hidden;
Expand Down Expand Up @@ -287,6 +288,9 @@ body.full-screen-terminal {
width: 0;
display: inline-block;
}
.cmd .cmd-line {
white-space: nowrap;
}
.terminal span[data-text],
.cmd span[data-text] {
display: inline-block;
Expand Down
6 changes: 5 additions & 1 deletion css/jquery.terminal.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* Copyright (c) 2011-2023 Jakub T. Jankiewicz <https://jcubic.pl/me>
* Released under the MIT license
*
* Date: Sun, 07 Apr 2024 16:50:24 +0000
* Date: Sun, 07 Apr 2024 17:14:02 +0000
*/
.terminal .terminal-output .format, .cmd .format,
.cmd-prompt, .cmd-prompt div {
Expand Down Expand Up @@ -83,6 +83,7 @@
scrollbar-gutter: stable;
height: 100%;
box-sizing: border-box;
overflow-x: hidden;
}
terminal.terminal-temp {
visibility: hidden;
Expand Down Expand Up @@ -287,6 +288,9 @@ body.full-screen-terminal {
width: 0;
display: inline-block;
}
.cmd .cmd-line {
white-space: nowrap;
}
.terminal span[data-text],
.cmd span[data-text] {
display: inline-block;
Expand Down
4 changes: 2 additions & 2 deletions css/jquery.terminal.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/jquery.terminal.min.css.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/jquery.terminal.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
*
* broken image by Sophia Bai from the Noun Project (CC-BY)
*
* Date: Sun, 07 Apr 2024 16:52:49 +0000
* Date: Sun, 07 Apr 2024 17:14:01 +0000
*/
/* global define, Map, BigInt */
/* eslint-disable */
Expand Down Expand Up @@ -5305,7 +5305,7 @@
// -------------------------------------------------------------------------
$.terminal = {
version: 'DEV',
date: 'Sun, 07 Apr 2024 16:52:49 +0000',
date: 'Sun, 07 Apr 2024 17:14:01 +0000',
// colors from https://www.w3.org/wiki/CSS/Properties/color/keywords
color_names: [
'transparent', 'currentcolor', 'black', 'silver', 'gray', 'white',
Expand Down
4 changes: 2 additions & 2 deletions js/jquery.terminal.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/jquery.terminal.min.js.map

Large diffs are not rendered by default.

0 comments on commit ddf9107

Please sign in to comment.