Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal does not work in iPad #36

Closed
billyzkid opened this issue Apr 29, 2012 · 29 comments
Closed

Terminal does not work in iPad #36

billyzkid opened this issue Apr 29, 2012 · 29 comments
Assignees
Labels

Comments

@billyzkid
Copy link

Focus on the terminal does not bring up the iPad keyboard so there is no way to provide input.

@jcubic
Copy link
Owner

jcubic commented Apr 29, 2012

It's because there is no real html input there, Maybe add input or use clipboard hidden textarea to always have focus on it will fix it. It will not work on iPhone too. I can fix the issue but I'll have no way to test it because I don't have iPad.

@ghost ghost assigned jcubic Apr 29, 2012
@billyzkid
Copy link
Author

A little googling makes it sound like the input tag is the only reliable way to get the keyboard, especially older versions of iOS (<5) where contentEditable is not supported.

@jcubic
Copy link
Owner

jcubic commented May 3, 2012

Thanks, as I said before the only way is to add hidden input or use textarea, I will use input and also fix issue with out of focus when you click out of terminal.

@usmanajmal
Copy link

Jakub, any update on providing support for iPad devices? I can help you test this on iOS and Android based devices if you like.

@jcubic
Copy link
Owner

jcubic commented Jul 12, 2012

I've work on Android fix http://terminal.jcubic.pl/android.html but there is issue with keyboard and scrolling.

BTW: wterminal don't work very well on Android either, the keyboard turn off when you type enter. And you need to click on text input when for keyboard to show up.

@usmanajmal
Copy link

Just tried it on an iPhone. iOS keyboard appears finely. I don't know what keyboard and scrolling issue you are referring to but here is what I noticed:
If I type 5+3 at js prompt and press ENTER key, 8 appears fine but screen actually does not automatically move up and 8 kind of hides behind the keyboard.

Reference pictures:

  1. In following picture 8 is hiding behind the keyboard: http://tinypic.com/view.php?pic=bg2u69&s=6
  2. If I scroll above the screen manually I do see 8 as shown in following figure but I guess screen should automatically move above: http://tinypic.com/view.php?pic=2lkb2br&s=6

I don't have an iPad available right now but I can test it on one tomorrow and let you know about results.

@usmanajmal
Copy link

@jcubic
Copy link
Owner

jcubic commented Jul 12, 2012

This is exactly the issue about scrolling I had, but it look like on iPhone it work better then in Andorid. If I type something I can't scroll at all (I use a while ago touch scroll jQuery plugin I can try to use it). the page is automatically scrolling but only when I type lots of commands (when there are more commands then there are visible and those that are behind keyboard). On Andorid the size of the page don't change when keyboard appear.

@usmanajmal
Copy link

This should help fix the issue on iOS devices: https://github.com/vital101/jScroll/tree/master/example

@jcubic
Copy link
Owner

jcubic commented Jul 23, 2012

Can you include that script to your page use it on iOS device and do

$('.terminal').jScroll();

or

$('????').terminal(function(cmd, t) { ... }, { <options> }).jScroll();

and check if it's working, if yes then you can just use it, there is no reason to include this code, (mouseweel is little different - line 2380 because there is some initialization code there but maybe I should remove it too, and create documentation how to use those libraries).

PS: I try to use zepto.js touch events and jquery mobile but it's way to many code and I couldn't extract only that I was needing (I extract some code from those libraries but it was not working). Maybe I will need to implement my own touchscroll library that will work on Android (and maybe on iOS too) I start to play with it.

@ayr-ton
Copy link

ayr-ton commented Aug 20, 2012

@jcubic How is it going?

@jcubic
Copy link
Owner

jcubic commented Aug 20, 2012

Not much, I don't work on it since last comment. I don't have iPad device, and on Andorid phone scroll don't work. I will try again to fix scrolling, but I think that virtual keyboard can't be fix on Android (text is beneath the keyboard), maybe on iPad it's different.

@ayr-ton
Copy link

ayr-ton commented Aug 20, 2012

@jcubic Let me know if I can help in your working progress. I have access to IOs and Androids in resolutions for Smartphone and Tablet.
Give me a call if you want me to test in Ipad or help coding. I will be online :-)

@usmanajmal
Copy link

@jcubic I am sorry. Couldn't find time yet to test this. I will test it soon if @ayrtonfreeman doesn't before me. :)

@ayr-ton
Copy link

ayr-ton commented Aug 21, 2012

@usmanajmal I will test jScroll at night and let you guys know if it fix the scroll problems.
At the time, the virtualkeyboard works fine same in IOs and Android, using the last version of jquery-terminal. I'm just having issues with crazy scroll.

@jcubic
Copy link
Owner

jcubic commented Aug 21, 2012

I found another jquery scroll plugin
http://www.areaaperta.com/nicescroll/
I will try it on Android.

On Tue, 21 Aug 2012 06:38:07 -0700
Ayrton Araújo notifications@github.com wrote:

@usmanajmal I will test jScroll at night and let you guys know if it
fix the scroll problems. At the time, the virtualkeyboard works fine
same in IOs and Android, using the last version of jquery-terminal.
I'm just having issues with crazy scroll.


Reply to this email directly or view it on GitHub:

#36 (comment)

Jakub Jankiewicz, Web Developer
http://jcubic.pl

@ayr-ton
Copy link

ayr-ton commented Aug 21, 2012

Actually the keyboard is not working in IOs. I've tested again.

@marcusramberg
Copy link

For some reason the keyboard appears in the demo on the front page (although scrolling ofset is wrong) but not in the other demos.

@shellstrom
Copy link

This issue is very old, I know, but mobiles are after all, in my opinion, pretty widely used types of devices.

This issue is also still open. There is some closed commit reference but I'm not sure if it fixes this specific issue, if it works with 0.7.7 or if it works for Android.

I understand I can take a look at the implementation and see whether I can do something about it there has been some work done so far it seems. The question is; how do we move forward? Can we move forward? (Do we have to move forward? Is there a fix already?)
Based on what I have currently, the keyboard on my Nexus 7 is popping up with the 0.7.7 version of this product. I can also zoom and pan.

When typing, it does not seem to catch any characters. When pressing enter, a new line is output. On the android.html test page I get a bit random results. No characters are catched. When pressing Enter I get:
$>
447
447
110
124
138
$>
447
447
194
208
222
$>
447
447
278
292
306
.....

@jcubic
Copy link
Owner

jcubic commented Nov 7, 2013

Those numbers are heights of different elements look at the source. On andorid when you type more stuff it's hidden bellow the virtual keyboard and there is no way to fix it, so I give up. Maybe I've done some changes that make don't work on Android anymore I've not tested, but since you can't know how big virtual keyboard is you can't work on android with this terminal.

I didn't test on iPhone or iPad I don't have those devices.

And last thing @ayr-ton fix the issue by removing jquery terminal and using different plugin.

@ayr-ton
Copy link

ayr-ton commented Nov 8, 2013

=x

@jcubic
Copy link
Owner

jcubic commented May 24, 2014

I'll try to use Mottie/Keyboard to create IME for terminal, so this should solve any issues with virtual keyboard for iPad and Andorid.

@jcubic
Copy link
Owner

jcubic commented May 24, 2014

I've created a demo of terminal working with keyboard. Will check with mobile, I think that it require to use jquery mobile.

@jcubic
Copy link
Owner

jcubic commented Jun 1, 2014

#39 is fixed.

@jcubic
Copy link
Owner

jcubic commented Jul 28, 2014

Anybody can test http://terminal.jcubic.pl/android.php on iPad? (You should get echo text on each keypress, it's debug code).

@hervehobbes
Copy link

It's running on my iPad mini with iOS 9.2

@jcubic
Copy link
Owner

jcubic commented Dec 26, 2015

Does it work or doesn't?

@hervehobbes
Copy link

Yes, it works

@jcubic
Copy link
Owner

jcubic commented Dec 26, 2015

Great thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants