Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hitting any keys after pasting the content will clear the content #493

Closed
phuc opened this issue May 17, 2019 · 3 comments
Closed

Hitting any keys after pasting the content will clear the content #493

phuc opened this issue May 17, 2019 · 3 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@phuc
Copy link

phuc commented May 17, 2019

Expected behavior

Pasted content needs to be retained

Actual behavior

It clears all the content

Steps to reproduce

  1. Copy some text
  2. Go to the demo at https://terminal.jcubic.pl/#demo
  3. Paste the text
  4. Hit spacebar
  5. All content is clear

Browser and OS

  1. Browse: Chrome version 74.0.3729.157 (Official Build) (64-bit)
  2. OS: MacOS version 10.12.6
@jcubic
Copy link
Owner

jcubic commented May 17, 2019 •
edited

It works on Linux Chromium. Will check on Browserstack in few days. Can you reproduce on other OS/Browser?

@phuc
Copy link
Author

phuc commented May 17, 2019

I tried with Chrome on Windows 10 and Ubuntu 16. Both are working fine. It seems like it's only broken in Chrome on Mac.

jcubic added a commit that referenced this issue May 18, 2019
@jcubic
update textarea when calling insert - fix paste + key on Mac/Chrome #493
6e07eca
@jcubic jcubic added Bug resolved if issue is resolved, it will be open until merge with master labels May 18, 2019
@jcubic
Copy link
Owner

jcubic commented May 18, 2019

The fix got released in version 2.5.2

@jcubic jcubic closed this as completed May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcubic @phuc