Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTRL+C jump to terminal when not in focus #499

Closed
jcubic opened this issue May 27, 2019 · 0 comments
Closed

CTRL+C jump to terminal when not in focus #499

jcubic opened this issue May 27, 2019 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented May 27, 2019

Expected behavior

press CTRL+C should proccess text only if selection is inside terminal

Actual behavior

CTRL+C just to terminal when you try to copy something and you scroll the page so terminal is out of view.

Steps to reproduce

Open https://terminal.jcubic.pl/
try to copy some text (it will jump to last created terminal which are comments).
@jcubic jcubic added the Bug label May 27, 2019
jcubic added a commit that referenced this issue Jun 1, 2019
@jcubic
fix CTRL+C when terminal not in focus and terminal text is not selected
b832ea6 
#499
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jun 1, 2019
@jcubic jcubic closed this as completed Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic