Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a Catton phenomenon in jquery.terminal input or deletion #506

Closed
YanFang150602 opened this issue Jun 22, 2019 · 10 comments
Closed
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@YanFang150602
Copy link

Expected behavior

Input or delete operations are fluent

Actual behavior

There is a Catton phenomenon in jquery.terminal input or deletion

Steps to reproduce

Press a button all the time

Browser and OS

Chrome or Edge or IE
win7

@jcubic
Copy link
Owner

jcubic commented Jun 22, 2019

Sorry but what is "Catton phenomenon"? Can you explain more?

@YanFang150602
Copy link
Author

Keep pressing a key to input. At the beginning, one input comes in, and then more than one input will come together.
Press Backspce all the time. At the beginning, one will be deleted, the rest will be deleted all at once, without a deletion process.

@YanFang150602
Copy link
Author

Delete operation :
image

@jcubic
Copy link
Owner

jcubic commented Jun 23, 2019

This is not a bug, this is how terminal work, there is single keypress and repeated HOLD+ modifier, when you hold a key it will keep inserting that key, the same as with any input in any browser. You will never got single key when you press and hold a key. With backspace it was created the same as in Android where you can keep deleting words before cursor when you hold the key.

Will check IE and Edge if it's any different.

@YanFang150602
Copy link
Author

YanFang150602 commented Jun 24, 2019

It is always inserted, but after a long time, frame freezing begins.

The user thinks this should have the same effect as the command prompt. Always press a key, one input after another to enter, one delete.

@jcubic
Copy link
Owner

jcubic commented Jun 24, 2019

I don't know what terminal you're using but holding key on linux keeps adding characters not single character, and press and hold delete key keep deleting the characters, not single character. I can only make delete word when hold key to be only on mobile.

@jcubic
Copy link
Owner

jcubic commented Jul 31, 2019

@YanFang150602 can you tell my on what browser/OS you see the issue?

Keep pressing a key to input. At the beginning, one input comes in, and then more than one input > will come together.

This should never happen. When I've tested this, it was working fine on Linux/Chromium

Press Backspce all the time. At the beginning, one will be deleted, the rest will be deleted all at
once, without a deletion process.

This is mainly done to work like on mobile, this is a feature, I can restrict this to only mobile.

@jcubic jcubic added Need testing Unclear Need proper explanation and steps to reproduce or Demo and removed Need testing labels Jul 31, 2019
jcubic added a commit that referenced this issue Aug 29, 2019
@jcubic
Copy link
Owner

jcubic commented Aug 29, 2019

Now mobile delete is disabled by default (default value is true on mobile) you can force it with mobileDelete option.

@jcubic jcubic added feature resolved if issue is resolved, it will be open until merge with master and removed Unclear Need proper explanation and steps to reproduce or Demo labels Aug 29, 2019
@jcubic
Copy link
Owner

jcubic commented Aug 29, 2019

released in 2.8.0

@jcubic jcubic closed this as completed Aug 29, 2019
@jcubic
Copy link
Owner

jcubic commented Aug 29, 2019

if it still don't work please reopen and create demo with reproduction with latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

2 participants