Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images from formatters inside cmd #519

Closed
jcubic opened this issue Sep 3, 2019 · 2 comments
Closed

Images from formatters inside cmd #519

jcubic opened this issue Sep 3, 2019 · 2 comments
Labels
Bug low resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 3, 2019

Expected behavior

Images should be rendered inside cmd

Actual behavior

Bracket is rendered after the image

Steps to reproduce

$.terminal.defaults.formatters = [[/:\)/g, '[[@;;;;https://unpkg.com/emoji-datasource-twitter@4.1.0/img/twitter/64/1f603.png]]']]
term.insert(':)');

I doubt anyone would like to render images in cmd but this should work since formatter can return any formatting including images.

@jcubic
Copy link
Owner Author

jcubic commented Sep 3, 2019

Also cmd don't render attributes for some reason:

$.terminal.defaults.formatters = [[/:\)/g, '[[@;;;;https://unpkg.com/emoji-datasource-twitter@4.1.0/img/twitter/64/1f603.png;{"style":"width:32px"}]]']]
term.settings().allowedAttributes.push('style')
term.insert(':)');

with echo it works fine.

@jcubic jcubic changed the title Closing bracket in Images from formatters Images from formatters inside cmd Sep 3, 2019
@jcubic
Copy link
Owner Author

jcubic commented Dec 22, 2019

Bracket fixed by #550 but one issue is that you can't put cursor after the command. it always at last character.

jcubic added a commit that referenced this issue Dec 22, 2019
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 22, 2019
@jcubic jcubic closed this as completed Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug low resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant