Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete finalize after first error #524

Closed
jcubic opened this issue Sep 11, 2019 · 1 comment
Closed

Delete finalize after first error #524

jcubic opened this issue Sep 11, 2019 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 11, 2019

Expected behavior

If there is error in echo finalize I should see only one error in console

Actual behavior

it prints errors in each resize

Steps to reproduce

term.echo('xxx', {
  finalize: function() {
      x();
  }
});
@jcubic
Copy link
Owner Author

jcubic commented Sep 14, 2019

The problem was more complex the finalize was already removed, the issue was that display exception was triggering flush before buffer was cleared. The solution was to remove item from buffer before calling finalize. while + buff.shift() instead of $.each.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Sep 14, 2019
@jcubic jcubic closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant