Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClear should be called before clear the DOM #527

Closed
jcubic opened this issue Sep 11, 2019 · 0 comments
Closed

onClear should be called before clear the DOM #527

jcubic opened this issue Sep 11, 2019 · 0 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 11, 2019

I have idea for a new feature for jQuery Terminal

so you can clean up the html, like revoke DataURL you created in one place. It will be useful to allow return false to prevent clear.
@jcubic jcubic added the feature label Sep 11, 2019
jcubic added a commit that referenced this issue Oct 13, 2019
@jcubic
call onClear before clear and allow to cancel #527
bc6815b
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Oct 13, 2019
@jcubic jcubic closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic