Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echo array break on refresh #540

Closed
jcubic opened this issue Nov 16, 2019 · 2 comments
Closed

echo array break on refresh #540

jcubic opened this issue Nov 16, 2019 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Nov 16, 2019

Expected behavior

Array should show columns after refresh

Actual behavior

it show list of comma separated text without spaces

Steps to reproduce

  1. Open ANSI terminal
  2. type ls
  3. resize the window
@jcubic jcubic added the Bug label Nov 16, 2019
@jcubic
Copy link
Owner Author

jcubic commented Nov 16, 2019

This also happen if scrollbar appear that make terminal content resize. Refresh in this case is not a bug.

jcubic added a commit that referenced this issue Nov 24, 2019
@jcubic
fix echo array + refresh #540 & call update with DOM nodes
42e3310
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Nov 24, 2019
@jcubic
Copy link
Owner Author

jcubic commented Nov 24, 2019

The issue was happening when outputLimit option was used. Value converted to string two times, when the option was used, and the first didn't convert array properly. Removing that pre processing solved the issue.

@jcubic jcubic closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic