Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a line with nested formatting ignores inner format #543

Closed
taikuukaits opened this issue Nov 22, 2019 · 2 comments
Closed

Updating a line with nested formatting ignores inner format #543

taikuukaits opened this issue Nov 22, 2019 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@taikuukaits
Copy link

Expected behavior

Updating a line with nested formatting should respect and display the nested format.

Actual behavior

The inner format text is shown on the terminal. The inner format does not work.

Steps to reproduce

I've reproduced in the forked codepen, all you have to do is this:

{code}
var nestedFormat = "[[b;;] bold [[;green;] green]]";
term.echo("works: " + nestedFormat);
term.echo("broke: " + nestedFormat);
term.update(-1, "broke: " + nestedFormat);
{code}

The works line is what I expect, but you can see the behavior in the broke line.

https://codepen.io/taikuukaits/pen/QWWPEWQ

Browser and OS

Chrome and Windows

I didn't see any similar issues and not sure if I am doing something wrong. Any help would be appreciated. Thanks!

@taikuukaits taikuukaits changed the title Issue with updating a line that has nested formatting Updating a line that with nested formatting ignores inner format Nov 22, 2019
@taikuukaits taikuukaits changed the title Updating a line that with nested formatting ignores inner format Updating a line with nested formatting ignores inner format Nov 22, 2019
@jcubic jcubic added the Bug label Nov 22, 2019
@jcubic
Copy link
Owner

jcubic commented Nov 24, 2019

Issue fixed in devel branch, it will be in next version. Thanks for the report good finding.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Nov 24, 2019
@jcubic jcubic closed this as completed Nov 25, 2019
@jcubic
Copy link
Owner

jcubic commented Nov 27, 2019

Forget to add the fix is in 2.9.0 and your codepen is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

2 participants