Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_options should not convert parsed arguments to strings #547

Closed
jcubic opened this issue Dec 15, 2019 · 0 comments
Closed

parse_options should not convert parsed arguments to strings #547

jcubic opened this issue Dec 15, 2019 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 15, 2019

Expected behavior

I should get regex if call call parse_options with regex.

Actual behavior

everything is converted to strings if they are not strings.

Steps to reproduce

$.terminal.parse_options([/xxx/, '-b', 10])
// {_: ["/xxx/"], b: "10"}
@jcubic jcubic added the Bug label Dec 15, 2019
jcubic added a commit that referenced this issue Dec 18, 2019
@jcubic
don't stringify in parse_options #547
79cc2b8
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Dec 18, 2019
@jcubic jcubic closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic