Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can paste into command mode of less #581

Closed
jcubic opened this issue May 27, 2020 · 1 comment
Closed

You can paste into command mode of less #581

jcubic opened this issue May 27, 2020 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented May 27, 2020

Issue summary

If less expect the command (the only one that insert text is "/" other do actions) you can paste the text and break the plugin

Expected behavior

Paste should be disabled

Actual behavior

You can paste text

Steps to reproduce

  1. Open less demo https://codepen.io/jcubic/pen/zEyxjJ
  2. Types less
  3. Copy/Paste something
  4. You can remove the pasted text
@jcubic jcubic added the Bug label May 27, 2020
@jcubic
Copy link
Owner Author

jcubic commented May 27, 2020

It will probably require to handle onPaste return false. Maybe refactor the paste to have one global event. Paste is handled in few places (in cmd - text and terminal - images).

jcubic added a commit that referenced this issue Jul 1, 2020
fix return false from onPaste
fix calling onPaste if it's in nested interpreter if no main settings set
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 1, 2020
@jcubic jcubic closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant