Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to prevent terminal from scrolling to the bottom on click #596

Closed
ovk opened this issue Jul 3, 2020 · 4 comments
Closed
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@ovk
Copy link

ovk commented Jul 3, 2020

Currently the terminal will scroll down to the bottom on click, even though it currently holds focus.

As was discussed in Gitter, having an option that prevents such behaviour would be really nice.

@jcubic jcubic added the feature label Jul 4, 2020
@jcubic
Copy link
Owner

jcubic commented Jul 4, 2020

Thanks for adding an issue, I think that it would be better for you case to just don't scroll it terminal is already in focus. But adding option to disable that completely is also nice idea.

@ovk
Copy link
Author

ovk commented Jul 4, 2020

Is there currently a way to prevent scrolling when terminal is in focus?

@jcubic
Copy link
Owner

jcubic commented Jul 4, 2020

No, I need to add this feature.

@jcubic
Copy link
Owner

jcubic commented Jul 6, 2020

The jumping was actually never intentional, the code just focus into textarea when you clik anywere on the page, and when terminal was scrolled up it jumped to bottom because textarea was inside command line.

Right now the textarea scroll with the terminal (or page with it's full screen) so focus into textarea never jump to bottom, and there is explicit scroll_to_bottom() call in case of clicking on terminal when it's not enabled.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 6, 2020
@jcubic jcubic closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

2 participants