Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined emoji don't work properly #598

Closed
jcubic opened this issue Jul 6, 2020 · 2 comments
Closed

Combined emoji don't work properly #598

jcubic opened this issue Jul 6, 2020 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 6, 2020

Issue summary

On Windows 10 default using emoji picker, default emoji don't render properly, they are split into multiple characters.

Expected behavior

All emoji work correctly

Actual behavior

Some emoji are broken

Steps to reproduce

  1. Open emoji demo
  2. it renders 3 characters. Both emoji-regex and emoji-data are correct maybe regex need to be updated and added in build time.
@jcubic jcubic added the Bug label Jul 6, 2020
@jcubic
Copy link
Owner Author

jcubic commented Jul 6, 2020

To build emoji you will need regexpu and emoji-regex by Mathias Bynens. It will be best to get them from npm and add to project at build time.

Best it would be to patch src file with new regex on each build. Check if file for make can be created with version of the emoji-regex taken from package.json. or .$(version) should be used to trigger to patch the src.js file.

@jcubic
Copy link
Owner Author

jcubic commented Jul 11, 2020

Main issue is fixed, there is still issue when click on the command line that have longer emoji. No need for updating emoji regex, this is something that could be done later so it's up to date.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jul 11, 2020
@jcubic jcubic closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant