Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension] Forms #610

Closed
6 tasks done
jcubic opened this issue Jul 26, 2020 · 2 comments
Closed
6 tasks done

[Extension] Forms #610

jcubic opened this issue Jul 26, 2020 · 2 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 26, 2020

I have an idea for a new feature for jQuery Terminal

The extension should include examples:

  • Create Settings object from questions. There is a lot of code that has this feature so it should be put into its own file (e.g. form.js).
  • Create demo for radio buttons (https://codepen.io/jcubic/pen/jOWRLex?editors=0010).
  • Create demo for checkboxes.
  • Add support for i18n of the strings (including boolean Y/N answers).
  • Incorporate demo in extension (that will expose each form item as function and form function that will generate object from answers similar to settings example).
  • TypeScript definition
@jcubic jcubic added the feature label Jul 26, 2020
@jcubic jcubic changed the title [Extension] Create Settings object from questions [Extension] Forms Jul 26, 2020
@jcubic
Copy link
Owner Author

jcubic commented Oct 21, 2020

The Codepen demo got updated, Unicode checkboxes and radio buttons give problems on Windows so they where replaced with ASCII (o) and [x].

@jcubic
Copy link
Owner Author

jcubic commented Oct 21, 2020

$.terminal.forms.form function in Codepen demo, will create object from settings. It's mixed ES5 and ES6 it need to be refactored to ES5 when added to repo (so everything is ES5 as base code).

jcubic added a commit that referenced this issue Jul 8, 2021
jcubic added a commit that referenced this issue Jul 8, 2021
@jcubic jcubic added resolved if issue is resolved, it will be open until merge with master and removed in progress labels Jul 8, 2021
jcubic added a commit that referenced this issue Aug 3, 2021
@jcubic jcubic closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant