Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keymap is broken in nested interpreter #615

Closed
jcubic opened this issue Jul 26, 2020 · 0 comments
Closed

Keymap is broken in nested interpreter #615

jcubic opened this issue Jul 26, 2020 · 0 comments
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 26, 2020 •
edited

Issue summary

Keymap are not restored but merged with nested interpreters

Expected behavior

I should use keymap in nested interpreter and it should be removed on pop()

Actual behavior

It's mixed up

Steps to reproduce

  1. Open Radio Button demo https://codepen.io/jcubic/pen/jOWRLex?editors=0110 .
  2. Remove keymap from main terminal options.
  3. Type select Foo Bar Baz.
  4. Selection option.
  5. Press enter.
  6. Use arrows keys or enter.
jcubic added a commit that referenced this issue Aug 1, 2020
@jcubic
fix broken keymap inheritance in nested interpreters #615
fb19078
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Aug 1, 2020
@jcubic jcubic closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic