Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken ANSI artwork #622

Closed
jcubic opened this issue Sep 10, 2020 · 5 comments
Closed

Broken ANSI artwork #622

jcubic opened this issue Sep 10, 2020 · 5 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Sep 10, 2020

Issue summary

Example ANSI artwork don't render properly

Steps to reproduce

Render this ANSI artwork https://16colo.rs/pack/impure77/xz-tce.ans

ANSI artwork

Terminal output:
ansi artwork error
@jcubic jcubic added the Bug label Sep 10, 2020
@jcubic
Copy link
Owner Author

jcubic commented Sep 10, 2020 •
edited

This is how it renders in Xfce terminal:
ANSI_term

The blinking can also be implemented using css animations.

@jcubic jcubic mentioned this issue Sep 10, 2020
Closed
@jcubic
Copy link
Owner Author

jcubic commented Sep 10, 2020 •
edited

Another examples:

@jcubic
Copy link
Owner Author

jcubic commented Sep 15, 2020

xz-bomba.ans and xz-tce.ans from impure77 pack will not be fixed. The artwok is create for different OS (Amiga) and it will be too hard to make it work. But N-CRYPT2.ANS is still an issue. It seems that part of the image is cut off in the middle.

@jcubic
Copy link
Owner Author

jcubic commented Sep 15, 2020

The only think that can be done to xz-tce.ans is to get rid of visible formatting (terminal markup).

@jcubic
Copy link
Owner Author

jcubic commented Sep 24, 2020

One more example of broken ANSI art: https://16colo.rs/pack/blocktr0nics30302020/67_Calendar_2020_06_June.ans

jcubic added a commit that referenced this issue Sep 26, 2020
@jcubic
fix for ANSI Art #622
91fc7a0
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Sep 26, 2020
jcubic added a commit that referenced this issue Sep 28, 2020
@jcubic
Fix wrong C ansi code #622
96ca7be 
fix wrong caluclation of cursor movement in print becasue of wrong
line line calculation, that didn't count for escaped entites.
jcubic added a commit that referenced this issue Sep 28, 2020
@jcubic
fix lint error #622
16fb260
jcubic added a commit that referenced this issue Sep 28, 2020
@jcubic
fixes and improvements to ANSI Art rendering #622
44a6e07 
Additional add support for blinking + handle print of Control points
@jcubic jcubic closed this as completed Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic