Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API that return size of single character and terminal #637

Closed
jcubic opened this issue Dec 30, 2020 · 0 comments
Closed

New API that return size of single character and terminal #637

jcubic opened this issue Dec 30, 2020 · 0 comments
Labels
feature resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 30, 2020

I have idea for a new feature for jQuery Terminal

New API that will return dimension of single character.

Terminal::char(): { width: number, height: number };

another idea is use:

type size = {
  width: number,
  height: number
};
interface geometry {
    terminal: size;
    char: size;
}
function geometry(): geometry {
    return {
        terminal: { width: 10, height: 10 },
        char: { width: 10, height: 10 },
    }
}

recalculation should only happen on resize and function should just return static object.

@jcubic jcubic added the feature label Dec 30, 2020
@jcubic jcubic changed the title New API that return size of single character New API that return size of single character and terminal Dec 30, 2020
jcubic added a commit that referenced this issue Feb 3, 2021
jcubic added a commit that referenced this issue Feb 3, 2021
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Feb 4, 2021
@jcubic jcubic closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant