Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize stopped working #677

Closed
jcubic opened this issue Jul 21, 2021 · 2 comments
Closed

Resize stopped working #677

jcubic opened this issue Jul 21, 2021 · 2 comments
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jul 21, 2021

Issue summary

If you close the browser and you have opened jQuery Terminal app. and you open the browser again and Terminal app is restored in background, then the width of the single char is probably 0 and everything is on one column.

Expected behavior

Terminal looks normalny

Actual behavior

All text is single column (each line have single character)

Steps to reproduce

  1. Open terminal demo
  2. Select different tab
  3. Close the browser
  4. Open browser again
  5. Switch to terminal demo

Browser and OS

Ubuntu GNU/Linux

Additional info

the fix may use: Page Visibility API.

@jcubic jcubic added the Bug label Jul 21, 2021
@jcubic jcubic changed the title Terminal have one char width when opened in background with browser tabs Resize stopped working Aug 2, 2021
@jcubic
Copy link
Owner Author

jcubic commented Aug 2, 2021

This is critical, the resize is not working anymore. This can be observed at https://codepen.io/jcubic/pen/WZvYGj the greetings is resizing but the text that got echoed is not wrapping when resized.

@jcubic
Copy link
Owner Author

jcubic commented Aug 2, 2021

The problem was a cache that contained wrapped ouput.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Aug 2, 2021
@jcubic jcubic closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug critical resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant