Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disarranged CSS style in raw HTML echoing #695

Closed
SuibianP opened this issue Sep 21, 2021 · 5 comments
Closed

Disarranged CSS style in raw HTML echoing #695

SuibianP opened this issue Sep 21, 2021 · 5 comments
Labels
Bug resolved

Comments

@SuibianP
Copy link

@SuibianP SuibianP commented Sep 21, 2021

Issue summary

display: flex gone and float: right not working when echoing raw HTML content, both seemingly due to an appended width: 100% style.

Expected behaviour

https://codepen.io/suibianp/pen/bGRKeLP

The first should be on a single line, with the embedded div floating to the right.

The second should have the children distributed evenly on a line.

Actual behaviour

The first is broken into two lines.

The second is squeezed together.

Steps to reproduce

https://codepen.io/suibianp/pen/YzQvWwY

Browser and OS

Firefox 92.0 (64-bit), Manjaro Linux

@jcubic
Copy link
Owner

@jcubic jcubic commented Sep 21, 2021

I think this is another bug that was introduced by a PR that I've merged. I keep fixing bugs since it was merged in April.
The code had a lot of hacks but I've liked the feature it introduced.

@jcubic jcubic added the Bug label Sep 21, 2021
@jcubic
Copy link
Owner

@jcubic jcubic commented Sep 21, 2021

And thanks for reporting the bug.

@jcubic
Copy link
Owner

@jcubic jcubic commented Sep 21, 2021

If you use some other tag instead of div it will work.

jcubic added a commit that referenced this issue Sep 21, 2021
The problem was that when you echo raw html with div tag
that div was affected by the code for echo without newline
@jcubic jcubic added the resolved label Sep 21, 2021
@jcubic
Copy link
Owner

@jcubic jcubic commented Sep 21, 2021

The fix is in the devel branch, it will be released in the next version.

@SuibianP
Copy link
Author

@SuibianP SuibianP commented Sep 21, 2021

Thank you very much for the fantastic package and rapid fix!

@jcubic jcubic closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved
Projects
None yet
Development

No branches or pull requests

2 participants