Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec array animation pause terminal after first command #722

Closed
jcubic opened this issue Dec 21, 2021 · 1 comment
Closed

Exec array animation pause terminal after first command #722

jcubic opened this issue Dec 21, 2021 · 1 comment
Labels
Bug resolved

Comments

@jcubic
Copy link
Owner

@jcubic jcubic commented Dec 21, 2021

Issue summary

Exec array animation pause terminal after first command

Expected behavior

It should execute all commands and not pause, unless the command is async

Actual behavior

Terminal is paused after first command

Steps to reproduce

  1. Open JS Demo
  2. Open Dev tools and exeute:
$.terminal.active().exec(['100000', '222222', '44444444'], {typing: true, delay: 50})
@jcubic jcubic added the Bug label Dec 21, 2021
@jcubic
Copy link
Owner Author

@jcubic jcubic commented Dec 23, 2021

The problem is when command is sync. If the command is animated or async it works fine.

var term = $('body').terminal(function(command) {
    const cmd = $.terminal.parse_command(command);
    if (cmd.name === 'echo') {
        this.echo(cmd.rest);
    }
});
term..exec(['echo 111111', 'echo 222222', 'echo 33333'], {typing: true, delay: 50});

@jcubic jcubic added the resolved label Dec 23, 2021
@jcubic jcubic closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved
Projects
None yet
Development

No branches or pull requests

1 participant