Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism don't work with exec typing animation #726

Closed
jcubic opened this issue Dec 27, 2021 · 2 comments
Closed

Prism don't work with exec typing animation #726

jcubic opened this issue Dec 27, 2021 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Dec 27, 2021

Issue summary

The prism is applied only for echo and command and typing animation use prompt. You can fix this by adding:

$.terminal.prism_formatters.prompt = true;

But then formatter is applied to original prompt as well.

Expected behavior

Exec with typing animation should show syntax highlighting while the animation running

Actual behavior

No syntax visible until animation finishes

Steps to reproduce

  1. Open Terminal Demo
  2. type demo()
@jcubic jcubic added the Bug label Dec 27, 2021
@jcubic
Copy link
Owner Author

jcubic commented Dec 27, 2021

The solution may be to add additional type for formatters: "animation" so Prism will be able to use it.

@jcubic
Copy link
Owner Author

jcubic commented Dec 27, 2021

The website was updated and $.terminal.prism_formatters.prompt = true; was added.

jcubic added a commit that referenced this issue Jan 5, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jan 5, 2022
jcubic added a commit that referenced this issue Feb 9, 2022
@jcubic jcubic closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant