Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid JSON warning from 16colo.rs bookmark #735

Closed
jcubic opened this issue Jan 12, 2022 · 1 comment
Closed

Invalid JSON warning from 16colo.rs bookmark #735

jcubic opened this issue Jan 12, 2022 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jan 12, 2022

Issue summary

There is some kind of error when processing ANSI art and using the get_inherit_style inside nested_formatting.

Expected behavior

No warnings, processing ANSI art has no issues

Actual behavior

Warning in console is visible when processing text at the bottom of the artwork

Steps to reproduce

  1. Open https://16colo.rs/pack/icon0896/GR-UNTY.ANS
  2. Run the bookmark: https://github.com/jcubic/terminal-bookmarks/blob/master/16colors.js
@jcubic jcubic added the Bug label Jan 12, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Feb 9, 2022
@jcubic
Copy link
Owner Author

jcubic commented Feb 9, 2022

The issue was that the code used split(';') on formatting but the formatting had HTML entities so it tried to parse JSON (last object of formatting) as part of the text.

@jcubic jcubic closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant