Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic prompt change flicker on enter #757

Closed
jcubic opened this issue Mar 8, 2022 · 1 comment
Closed

Dynamic prompt change flicker on enter #757

jcubic opened this issue Mar 8, 2022 · 1 comment
Labels
Bug won't fix
Milestone
2.33.0

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 8, 2022 •
edited
Loading

Issue summary

If you create a dynamic prompt (function) and change that prompt. The change makes the prompt show an old prompt for a split second (it's not always visible because it's fast).

Expected behavior

The old prompt should not be visible

Actual behavior

The old prompt is visible

Steps to reproduce

  1. Open Prompt Demo
  2. run set ~

Browser and OS

All
@jcubic jcubic added the Bug label Mar 8, 2022
@jcubic jcubic changed the title First change of dynamic prompt flicker Dynamic prompt change flicker on enter Mar 17, 2022
jcubic added a commit that referenced this issue Mar 17, 2022
@jcubic
fix flicker of dynamic prompt on enter #757
b36d790
@jcubic jcubic added resolved if issue is resolved, it will be open until merge with master and removed resolved if issue is resolved, it will be open until merge with master labels Mar 17, 2022
@jcubic jcubic added this to the 2.33.0 milestone Mar 26, 2022
jcubic added a commit that referenced this issue May 3, 2022
@jcubic
fix flicker of dynamic prompt #757
4bc1a1f
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 3, 2022
jcubic added a commit that referenced this issue May 3, 2022
@jcubic
Revert "fix flicker of dynamic prompt #757"
64d529a 
This reverts commit 4bc1a1f.
@jcubic
Copy link
Owner Author

jcubic commented May 3, 2022

This breaks more than it fixes. So I've had to revert the fix.

The fix is to use async command and it will work:

@jcubic jcubic closed this as completed May 3, 2022
@jcubic jcubic added won't fix and removed resolved if issue is resolved, it will be open until merge with master labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug won't fix
Projects
None yet
Milestone
2.33.0
Development

No branches or pull requests
1 participant
@jcubic