Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM nodes are re-rendered on resize #759

Closed
2 tasks done
jcubic opened this issue Mar 11, 2022 · 2 comments
Closed
2 tasks done

DOM nodes are re-rendered on resize #759

jcubic opened this issue Mar 11, 2022 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 11, 2022

Issue summary

DOM nodes are reinserted on resizing which causes iframes to reload.

Expected behavior

I expect the iframe added to DOM to not reset

Actual behavior

Iframe is reload

Steps to reproduce

  1. Open image/iframe echo demo
  2. Type iframe
  3. Type something into the embedded terminal
  4. Resize the page

Additional Notes

It would be nice if the echo jQuery object work like canvas animation in the rederHandler demo that is rendered only once, and the state is preserved

TODO:

@jcubic jcubic added the Bug label Mar 11, 2022
@jcubic
Copy link
Owner Author

jcubic commented Mar 11, 2022

This may be problematic: How to prevent an iframe from reloading when moving it in the DOM. Maybe the only way is to not touch the DOM for the iframe. Not sure if this is feasible.

@jcubic
Copy link
Owner Author

jcubic commented Mar 12, 2022

It seems that normal lines are not rendered unless there is a change when the line becomes smaller or bigger than the width of the terminal. So only raw output is re-rendered.

@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Mar 17, 2022
@jcubic jcubic added this to the 2.33.0 milestone Mar 26, 2022
@jcubic jcubic closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant