Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing animation don't respect mask #770

Closed
jcubic opened this issue Mar 28, 2022 · 0 comments · Fixed by #774
Closed

Typing animation don't respect mask #770

jcubic opened this issue Mar 28, 2022 · 0 comments · Fixed by #774
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 28, 2022

Issue summary

If you use typing animation on input that is masked the text is visible.

Expected behavior

I should see typing animation with mask

Actual behavior

I can see the text on the terminal

Steps to reproduce

  1. Create terminal with login
  2. Call term.exec(['guest', 'guest'], { typing: true });

Browser and OS

NA

Additional notes

$('body').terminal({}, {
    login(username, password) {
        if (username === 'guest' && password === 'guest') {
            return '<TOKEN>';
        }
    }
});
term.exec(['guest', 'guest'], { typing: true });

Note: that in master the not async login function doesn't work (it was already fixed).

@jcubic jcubic added the Bug label Mar 28, 2022
@jcubic jcubic added this to the 2.33.0 milestone Mar 28, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Mar 28, 2022
jcubic added a commit that referenced this issue Mar 28, 2022
@jcubic jcubic closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant