Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line wrapping doesn't work with echo without newline and prompt #773

Closed
2 tasks done
jcubic opened this issue Apr 10, 2022 · 0 comments
Closed
2 tasks done

Line wrapping doesn't work with echo without newline and prompt #773

jcubic opened this issue Apr 10, 2022 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 10, 2022

Issue summary

The line is not properly wrapped when using echo without a newline

Expected behavior

The line is properly wrapped

Actual behavior

The line is not wrapped and text typed into the terminal is indented.

Steps to reproduce

  1. Open Fake Linux Terminal Demo https://codepen.io/jcubic/pen/bzYQNw?editors=0011
  2. Open Console and run
  3. $.terminal.active().echo('This is longer text without newline', { newline: false })

The prompt is wrapped on the boundary of formatting and the next line is indented (because of margin).

  1. Execute $.terminal.active().echo('This is longer text without newline', { newline: false }).set_prompt('>>>>>>>>>>>>>>')
  2. Resize the page

Browser and OS

NA

Additional notes

Those are two issues:

  • indentation of cmd
  • line wrapping
@jcubic jcubic added the Bug label Apr 10, 2022
jcubic added a commit that referenced this issue May 26, 2022
* fix line wrapping when when there is text without newline
* fix text selection of text echoed without newline
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 26, 2022
@jcubic jcubic closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant