Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll on Echo Problem on New Version 2.33.1 #777

Closed
KiddoV opened this issue May 6, 2022 · 3 comments
Closed

Scroll on Echo Problem on New Version 2.33.1 #777

KiddoV opened this issue May 6, 2022 · 3 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@KiddoV
Copy link
Contributor

KiddoV commented May 6, 2022

Issue summary

The scrollOnEcho was Ok on the old version (2.28) I think. I just updated to the latest (a lot of changes). Now it is not working anymore!

Steps to reproduce

Check my JSFiddle.
Scroll up/down a few time in the terminal.
After a few scrolling, you will see the terminal stop automatically scrolling to the bottom.

Browser and OS

Windows 10
Chrome, Webview2

Additional notes

https://jsfiddle.net/KiddoV/5srqhzLm/14/

I tested the old version 2.32.1 was OK. It just happen on the big version 2.33.0 (this version has a big update)

@jcubic
Copy link
Owner

jcubic commented May 13, 2022

I will investigate probably when the content is very large the scroll to the bottom doesn't work anymore. I've seen this when printing factorial of 8000 using big int in my other project.

It may be related to pixel density that was added in the last version and maybe also related to CSS.

@jcubic jcubic added the Bug label May 13, 2022
@jcubic
Copy link
Owner

jcubic commented May 13, 2022

What is the use of:

  $('.prompt').hide(0, function() {
    setTimeout(function() {
      $('.terminal-output').text('Connected');
      $('.prompt').delay(500).show(0); 
    }, 3000);    	
  });

jcubic added a commit that referenced this issue May 13, 2022
jcubic added a commit that referenced this issue May 13, 2022
@jcubic
Copy link
Owner

jcubic commented May 13, 2022

The problem was that there was a new element added - a .scroller, I don't remember why but it was required. The code that scrolls to the bottom was not updated to use that new element.

jcubic added a commit that referenced this issue May 13, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label May 13, 2022
@jcubic jcubic closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

2 participants