Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise rejections are ignored by terminal echo #790

Closed
jcubic opened this issue Jun 12, 2022 · 0 comments
Closed

Promise rejections are ignored by terminal echo #790

jcubic opened this issue Jun 12, 2022 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 12, 2022

Issue summary

Promise rejections are ignored by terminal echo

Expected behavior

It should print the error message and exception like normal errors

Actual behavior

Nothing is printed on terminal

Steps to reproduce

Execute:

function error() {
    return Promise.reject(new Error('Some Error'));
}

term.echo(error);
term.echo(error());

Browser and OS

NA

Additional notes

Demo: https://codepen.io/jcubic/pen/wvyRvjz?editors=0010

@jcubic jcubic added the Bug label Jun 12, 2022
jcubic added a commit that referenced this issue Jun 14, 2022
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Jun 14, 2022
@jcubic jcubic closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant