Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing animation should scroll to bottom while animating #791

Closed
jcubic opened this issue Jun 12, 2022 · 0 comments
Closed

Typing animation should scroll to bottom while animating #791

jcubic opened this issue Jun 12, 2022 · 0 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Milestone
2.35.0

Comments

@jcubic
Copy link
Owner

jcubic commented Jun 12, 2022 •
edited
Loading

Issue summary

When text is animating and new lines are added it doesn't scroll to the bottom

Expected behavior

It should scroll to the bottom if the page was at bottom while animating

Actual behavior

The scroll doesn't move

Steps to reproduce

  1. Open Gaiman Playground
  2. Change echo result["def"] with echo* result["def"], 0
@jcubic jcubic added the Bug label Jun 12, 2022
@jcubic jcubic added this to the 2.35.0 milestone Jul 30, 2022
jcubic added a commit that referenced this issue Sep 11, 2022
@jcubic
fix scroll to bottom while animating #791
9f29ed6
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Sep 12, 2022
jcubic added a commit that referenced this issue Sep 12, 2022
@jcubic
fix detecting bottom of the terminal #791
09ee668
@jcubic jcubic closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Milestone
2.35.0
Development

No branches or pull requests
1 participant
@jcubic