Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting from prompt visible on the terminal #922

Closed
jcubic opened this issue Apr 13, 2024 · 1 comment
Closed

Formatting from prompt visible on the terminal #922

jcubic opened this issue Apr 13, 2024 · 1 comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 13, 2024

Issue summary

Formatting from prompt visible on the terminal when both interpreter and prompt have formatting

Expected behavior

It should format the text

Actual behavior

It prints formatting as is

Steps to reproduce

  1. Open demo https://codepen.io/jcubic/pen/qBwyrmo?editors=0010
  2. Press enter

Browser and OS

Additional notes

It only happens when you return formatting from interpreter and prompt is a function that render formatting.

As a workaround, you can use this.echo() instead of return value from interpreter.

@jcubic jcubic added the Bug label Apr 13, 2024
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 14, 2024
@jcubic jcubic closed this as completed Apr 21, 2024
@jcubic
Copy link
Owner Author

jcubic commented Apr 21, 2024

This didn't get fixed. The formatting is still visible. It get fixed with async command.

@jcubic jcubic reopened this Apr 21, 2024
@jcubic jcubic removed the resolved if issue is resolved, it will be open until merge with master label Apr 21, 2024
jcubic added a commit that referenced this issue Apr 22, 2024
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 22, 2024
@jcubic jcubic closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant