Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash of old prompt on enter #926

Closed
jcubic opened this issue Apr 14, 2024 · 2 comments
Closed

Flash of old prompt on enter #926

jcubic opened this issue Apr 14, 2024 · 2 comments
Labels
Bug resolved if issue is resolved, it will be open until merge with master

Comments

@jcubic
Copy link
Owner

jcubic commented Apr 14, 2024

Issue summary

When you have a dynamic prompt (using variable) and command change that prompt, there is a flash of old prompt before the new is visible.

Expected behavior

The new prompt should render without flash

Actual behavior

There is flash of old prompt after enter

Steps to reproduce

  1. Open demo https://codepen.io/jcubic/pen/KKYBWog?editors=0010
  2. type cd ~/directory
  3. type cd /

Additional notes

This is related to #923

As a workaround, you can make the function that change the prompt async.

@jcubic jcubic added the Bug label Apr 14, 2024
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 20, 2024
@jcubic
Copy link
Owner Author

jcubic commented Apr 20, 2024

Fixed with #923

@jcubic jcubic closed this as completed Apr 21, 2024
@jcubic
Copy link
Owner Author

jcubic commented Apr 26, 2024

This is not fixed.

@jcubic jcubic reopened this Apr 26, 2024
@jcubic jcubic removed the resolved if issue is resolved, it will be open until merge with master label Apr 26, 2024
@jcubic jcubic added the resolved if issue is resolved, it will be open until merge with master label Apr 26, 2024
@jcubic jcubic closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug resolved if issue is resolved, it will be open until merge with master
Projects
None yet
Development

No branches or pull requests

1 participant