Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Basic SSL support #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

daurnimator
Copy link

Enable basic SSL support.
Essentially just uncomments the code in RabbitMQUtil.java

Further work should pass extra configuration options to the SSL library.

@prime8
Copy link

prime8 commented Apr 30, 2013

I don't think this pull request results in compilable code -- see daurnimator@63c62b5

@daurnimator
Copy link
Author

Actually it (suprsingly) compiled fine.
I started with a solution like you posted above, but switched to the method you can see in the commit.

Do you still want me to swap to the try/catch wrapper?

@prime8
Copy link

prime8 commented Apr 30, 2013

When I clone your repo and try to build the source from scratch and test it then I get compile errors.

My setup is java6/maven3. What have I missed?!

flume-ng-rabbitmq$ mvn clean test
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building Flume.RabbitMQ 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.3:clean (default-clean) @ flume-rabbitmq-channel ---
[INFO] Deleting file set: flume-ng-rabbitmq/target (included: [**], excluded: [])
[INFO] 
[INFO] --- maven-resources-plugin:2.3:resources (default-resources) @ flume-rabbitmq-channel ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory flume-ng-rabbitmq/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.0.2:compile (default-compile) @ flume-rabbitmq-channel ---
[INFO] Compiling 4 source files to flume-ng-rabbitmq/target/classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.120s
[INFO] Finished at: Tue Apr 30 11:51:43 EDT 2013
[INFO] Final Memory: 10M/111M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project flume-rabbitmq-channel: Compilation failure
[ERROR] flume-ng-rabbitmq/src/main/java/org/apache/flume/source/rabbitmq/RabbitMQSource.java:[61,52] unreported exception java.security.NoSuchAlgorithmException; must be caught or declared to be thrown

@daurnimator
Copy link
Author

Hmm, using mvn clean I get the same error.
Someone through partial compiles I ended up with a clean binary!

I'll go back to the try/catch wrapper.

@prime8
Copy link

prime8 commented May 12, 2013

I've merged this sequence of commits into my development branches at https://github.com/prime8/flume-ng-rabbitmq :-)

@daurnimator
Copy link
Author

FWIW I've been working more on this, and have an upcoming commit set to add cert verification (I sort of went a round-about way to add this, because I wanted to support the PEM format, rather than deal with Java KeyStores)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants