-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to service call target #68
Add support to service call target #68
Conversation
The support lacked also from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great timing, just after the migration to Typescript and GH actions.
You might want to send a PR to custom-card-helpers
as well as they should really be supporting this too.
As a complete noob to HA custom cards and the ecosystem, this PR would not have been possible with strong TypeScript types. 👍
I'm not sure if I'll have time to dig into their contribution guidelines etc., I've already got (paid) work piling up 😅. Even this was unnecessary for my current use case but thought I'll make some use of the time spent twiddling with this. |
@jcwillox Can we go with this or do you want to wait for |
Well, I'll be dammed someone already added support for this 2 months ago but they haven't released the update, custom-cards/custom-card-helpers@894aec4. pnpm add github:custom-cards/custom-card-helpers#ae86495 |
Oh boy. I'll have time to follow up on this after the holidays but you're welcome to pull in the changes to another branch and fix things up if you will. :) |
Sure thing, I've already got the code from when I was checking to see if we could just use the latest commit from custom card helpers. |
Thanks! One thing less on my TODO-list. 🙂 |
This allows setting a target to a
call-service
action, e.g.Resolves #40.