encode nil IDs as nil #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "normal" rails, the `id` (and hence the value of `#to_param`) is nil for records that have not yet been persisted. Previously, including the `Hashid::Rails` concern broke this behaviour, raising an exception when `Model.new.to_param` was called. (Cases where you might want to get the ID of a new model include serializing it over a JSON API where the "edit" endpoint returns a new model instance if one does not already exist.) This change handles the above case by checking for nil in `model.hashid_encode`.
jcypret
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "normal" Rails, the
id(and hence the value of#to_param) is nilfor records that have not yet been persisted.
Previously, including the
Hashid::Railsconcern broke this behaviour,raising an exception when
Model.new.to_paramwas called. (Cases whereyou might want to get the ID of a new model include serializing it over
a JSON API where the "edit" endpoint returns a new model instance if
one does not already exist.)
This change handles the above case by checking for nil in
model.hashid_encode.