Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ** splat operator to address deprecation warning in Ruby 2.7 #72

Merged

Conversation

alexford
Copy link
Contributor

@alexford alexford commented Aug 8, 2020

Meant to address the following warning:

/Users/aford/code/hashid-rails/lib/hashid/rails.rb:66: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/aford/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/activerecord-6.0.3.2/lib/active_record/associations.rb:1370: warning: The called method `has_many' is defined here

@jcypret jcypret self-requested a review August 9, 2020 18:26
Copy link
Owner

@jcypret jcypret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, appreciate the contribution @alexford 🙌!

I tested this against locally against a few versions combinations of Ruby (2.5, 2.6, 2.7) and Rails (4.x, 5x, 6x) and it looks good to me. I'll get this merged and a new patch release published 👍

@jcypret jcypret merged commit a102bdb into jcypret:master Aug 9, 2020
@jcypret
Copy link
Owner

jcypret commented Aug 10, 2020

Released in v1.4.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants