Fix parallax exception when multiple parallax mods are installed #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing Kcalbeloh, Parallax, OPM, and OPM_Parallax results in this exception:
I'm not sure what else might be affected but it's pretty clear that this code has no guards against this kind of exception, so it's going to skip all the rest of the config nodes: https://github.com/Gameslinx/Tessellation/blob/bc27cb8ec5dd33b335b3eb42e11fa75046dad180/ParallaxLoader.cs#L123
This error occurs because the
@
patch at the top level applies to all nodes unlike when it occurs inside a node. OPM_Parallax adds a secondParallax
top-level node for the OPM bodies, so the kcalbeloh patches apply to both: