Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AInput does not respect dark theme when type is set #48

Closed
lmeysel opened this issue Oct 18, 2022 · 2 comments · Fixed by #68
Closed

AInput does not respect dark theme when type is set #48

lmeysel opened this issue Oct 18, 2022 · 2 comments · Fixed by #68

Comments

@lmeysel
Copy link

lmeysel commented Oct 18, 2022

When explicitly specifying a type, the AInput component is rendered without respecting dark mode (seems like a general layout glitch, border colors are also not correct). Tried it with current master and npm package (v0.10.0)

<AInput type="text" />
image

<AInput />
image

@peterbud
Copy link
Contributor

I can confirm the issue, The playground and the doc site are working as the input element has a default background-color: transparent setting. If you don't have that, you will see the issue.

My suggestion is to add bg-transparent to a-base-input-child in the ABaseInput

- 'a-base-input-child w-full h-full absolute inset-0 rounded-inherit'
+ 'a-base-input-child w-full h-full absolute inset-0 rounded-inherit bg-transparent'

I can submit a PR if you agree with that approach.

@jd-solanki
Copy link
Owner

I just checked this is exactly what you said @peterbud

Awaiting your PR 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants