New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trouble building rpms on Centos 7.3 #88
Comments
|
Taking a look at other projects and their solutions: https://github.com/kennethreitz/tablib/blob/master/tablib/compat.py |
Well this is code compatibility, that's easy enough. Tenacity uses https://pypi.python.org/pypi/six for that. Problem is that it does not cover syntax changes like this is the problem here. |
@hguemar Do you have any idea on how to fix that? |
easiest way would be to just delete the file in the rpm spec for the python2 build |
I'm also hitting this when trying to package a new release for Ubuntu. It looks like there are a few areas where this syntax is used, making the code incompatible for python 2.
|
Fedora now switched to python 3.7, tenacity 4.9 uses async. |
to test on centos build with python2 and python3 e.g. python2: `python setup.py bdist_rpm --python /usr/bin/python2` python3: `python setup.py bdist_rpm --python /usr/bin/python3`
opened a PR here: #133 |
Should Python 2 versions be removed from the specifiers if the library is not Py2 compatible (as of v4.10, according to kragniz/python-etcd3#429 )? Actually, I see that the library is attempting to maintain Py2-compatibility by conditionally importing the _asyncio.py module, but the problem occurs if you try to proactively compile it. How about making _asyncio.py more robust to this? |
Tenacity is compatible with Python 2. Don't trust everything you read on the internet. |
Use the same pattern of conditional importing of _compat.py as used in __init__.py to ensure that _compat.py can be compiled on Python 2. Fixes jd#88
Use the same pattern of conditional importing of _compat.py as used in __init__.py to ensure that _compat.py can be compiled on Python 2. Fixes jd#88
I am trying to build the rpm for this project for python 2.7
when running command:
python setup.py bdist_rpm --python /usr/bin/python
I receive the error
What is the workaround for this?
The text was updated successfully, but these errors were encountered: