Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tenacity only works with Tornado 4.5 or above #99

Closed
jslvtr opened this issue Nov 17, 2017 · 1 comment
Closed

Tenacity only works with Tornado 4.5 or above #99

jslvtr opened this issue Nov 17, 2017 · 1 comment
Labels
enhancement

Comments

@jslvtr
Copy link

jslvtr commented Nov 17, 2017

Hello! I'm running on Tornado 4.4.3, but my tests fail with the following:

../app/thunderflock.py:58: in <module>
    wait=wait_fixed(DatabaseRetryConfig['retry_wait_seconds']))
../.venv/lib/python3.6/site-packages/tenacity/__init__.py:95: in wrap
    elif tornado and tornado.gen.is_coroutine_function(f):
E   AttributeError: module 'tornado.gen' has no attribute 'is_coroutine_function'

tornado.gen.is_coroutine_function was added in Tornado 4.5. Would be great to display this in the README (or add support for Tornado 4.4, ideally!).
jd added a commit that referenced this issue Nov 17, 2017
@jd
Mention Tornado minimum version in README
fccbedf 
Improves #99
@jd jd added the enhancement label Nov 17, 2017
@pshchelo
Copy link

I'd actually like to see support for as far back as tornado 4.2.1 as this is the version packaged in Ubuntu Xenial LTS.

I was hit by this recently, and spent quite some time trying to understand what was the reason (OpenStack Neutron was failing to start). I tried to run OpenStack master on Xenial, and manage it with Salt, and it appears salt-common/salt-minion is dependent on python-tornado... 🤦‍♂️

@tipabu tipabu mentioned this issue Jan 18, 2018
Merged
ghost pushed a commit that referenced this issue Jan 18, 2018
@tipabu
Don't fall over if an old version of tornado is installed
97cde0d 
Related to issue #99 -- even if we don't properly support old versions
of tornado, we can do better than raise an AttributeError if an old
version *just happens* to be installed.
@jd jd closed this as completed Apr 9, 2018
openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jun 15, 2018
@prometheanfire
tenacity only supports tornado >= 4.5.0
339872a 
We would need to raise the min of tornado to 4.5 to be 'most' correct.
See jd/tenacity#99 for details.

Change-Id: I5635c6a07c9a00b67e27aa4073314d12915b4d73
openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jun 15, 2018
@prometheanfire
tenacity only supports tornado >= 4.5.0
6765b26 
We would need to raise the min of tornado to 4.5.0 to be 'most' correct.
See jd/tenacity#99 for details
Alternatively we could raise the UC of tenacity to 4.9.0 or above,
but I think that would bring in the updated tornado anyway

Change-Id: Id9ab1de61ab7fba4381e9714f6b0ec6f11239cb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jd @pshchelo @jslvtr