Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better wait.WaitBaseT annotation #392

Merged
merged 4 commits into from
Feb 28, 2023
Merged

better wait.WaitBaseT annotation #392

merged 4 commits into from
Feb 28, 2023

Conversation

karech
Copy link
Contributor

@karech karech commented Feb 21, 2023

fixes #391

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

jd
jd previously approved these changes Feb 21, 2023
View reviewed changes
@jd
Copy link
Owner

jd commented Feb 21, 2023

@karech can you add a release note?

@mergify mergify bot dismissed jd’s stale review February 21, 2023 14:21

Pull request has been modified.

@karech
Copy link
Contributor Author

karech commented Feb 21, 2023

@jd done

jd
jd previously approved these changes Feb 22, 2023
View reviewed changes
@mergify mergify bot dismissed jd’s stale review February 23, 2023 06:43

Pull request has been modified.

@karech
Copy link
Contributor Author

karech commented Feb 28, 2023

@jd could you please take a look again ?

@mergify mergify bot merged commit 548c5d4 into jd:main Feb 28, 2023
@karech karech deleted the patch-1 branch March 1, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect wait.WaitBaseT annotation
3 participants
@karech @jd @dmitrii-sorokin-cndt