Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error #473

Closed
wants to merge 3 commits into from
Closed

Conversation

istrebitel-1
Copy link

  • If library installed from pypi, import were not correct

- If library installed from pypi, import were not correct
Copy link
Contributor

mergify bot commented Jun 17, 2024

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

@@ -650,7 +650,7 @@ def wrap(f: WrappedFn) -> WrappedFn:
return wrap


from tenacity.asyncio import AsyncRetrying # noqa:E402,I100
from tenacity._asyncio import AsyncRetrying # noqa:E402,I100
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong, there's no _asyncio module in the repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, you are right, but I still unable to import from installed lib
image
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in library generation, asyncio module now not creating

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maximlt check again pls

@Tenzer
Copy link

Tenzer commented Jun 17, 2024

I have narrowed it down to be due to the setuptools configuration: #471 (comment)

- Add asyncio to build package
@istrebitel-1
Copy link
Author

I have narrowed it down to be due to the setuptools configuration: #471 (comment)

yes, got same solution

- Added changelog
@jd
Copy link
Owner

jd commented Jun 17, 2024

Should be fixed by #474

@jd jd closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants