Dropped node version back to 8.9.0 while it is still in Maintenance LTS #298
Conversation
bigkraig
changed the title
|
Please update Travis to build against 8.9.0 as well. |
|
@Casz any idea whats going on with travis? I am not very familiar with how to configure this but I assumed adding another version of node wouldn't create new jobs that also ran the integration tests like that. |
…the default test run to not be a full integration test
|
@Casz all set!! |
|
I'm going to check and see if we can move the two version tests into their respective stages. Not sure if it will work tbh, but if it doesnt, ill just revert it. |
|
@jdalrymple it is possible :) Using matrix includes https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/.travis.yml |
|
@Casz That method gets rid of the stages though :(. I found this: travis-ci/travis-ci#8295 ? |
Modifying the tests to include two nodejs versions
|
So i added the modifications, but the integration tests seem to fail for 8.9.0. Not sure why exactly :s |
I think we just need to run the docker-compose as part of the 8.9.0 integration test, will know shortly. |
|
@Casz @jdalrymple all green! 👍 |
|
So the before_script part also had to be duplicated ? That's annoying lol. Looks good though! Ill merge and release tonight |
Fixing error in alias syntax
|
I think you can clean up the travis file even more 😅 Let me try it out. |
|
Nope 😢 |
|
Had my hopes up there for a moment @Casz |
|
So did I 😞 |
This came up in danger/danger-js#855 where we are adding GitLab support to Danger JS. I didn't see any specific reason to drop support for 8.x which is still supported until Dec 2019.