Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - export Webhook Interfaces #3514

Merged
merged 1 commit into from Jan 23, 2024

Conversation

elaine-mattos
Copy link
Contributor

Hi!

thanks for the awesome SDK and the newly added Webhook Interfaces!
However, I missed the export statement in your index.ts when trying to import them to my project, so here's the PR that does that! :)

@jdalrymple
Copy link
Owner

Oh wow. Fail haha thanks!

@elaine-mattos
Copy link
Contributor Author

Please let me know if there's anything I can do to get a green pipeline :)

@jdalrymple
Copy link
Owner

jdalrymple commented Jan 23, 2024

It looks good. It's a pipeline inefficiency. As of right now I don't automatically run the e2e tests since they are resource intensive. However, when the manual jobs aren't run, the pipeline is labeled as "failed" until they are run -_-. I haven't thought of a good work around haha

@jdalrymple jdalrymple added the type:bug Changes fix a minor bug label Jan 23, 2024
@jdalrymple jdalrymple merged commit 4d55c39 into jdalrymple:main Jan 23, 2024
2 of 3 checks passed
@jdalrymple
Copy link
Owner

🚀 PR was released in 39.33.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. type:bug Changes fix a minor bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants