Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing build files #3522

Merged
merged 16 commits into from Jan 29, 2024
Merged

Missing build files #3522

merged 16 commits into from Jan 29, 2024

Conversation

jdalrymple
Copy link
Owner

@jdalrymple jdalrymple commented Jan 29, 2024

Summary

Gitlab CI artifacts don't automatically get included in upstream jobs unless the job explicitly needs the job where those artifacts are created. Even if you need a job that is upstream from the one that build the artifacts.

Solution

  • Adding check at release job to ensure dist files are present before releasing.
  • Fixing monorepo package versions to avoid possible mismatch

fixes #3521

📦 Published PR as canary version: 39.33.3--canary.3522.1156475438.0

✨ Test out this PR locally via:

npm install @gitbeaker/cli@39.33.3--canary.3522.1156475438.0
npm install @gitbeaker/core@39.33.3--canary.3522.1156475438.0
npm install @gitbeaker/requester-utils@39.33.3--canary.3522.1156475438.0
npm install @gitbeaker/rest@39.33.3--canary.3522.1156475438.0
# or 
yarn add @gitbeaker/cli@39.33.3--canary.3522.1156475438.0
yarn add @gitbeaker/core@39.33.3--canary.3522.1156475438.0
yarn add @gitbeaker/requester-utils@39.33.3--canary.3522.1156475438.0
yarn add @gitbeaker/rest@39.33.3--canary.3522.1156475438.0

@jdalrymple jdalrymple added the release:canary Deploy canary release label Jan 29, 2024
@jdalrymple jdalrymple merged commit 546e5b6 into main Jan 29, 2024
6 checks passed
@jdalrymple jdalrymple deleted the hotfix/build-files branch January 29, 2024 17:35
@jdalrymple jdalrymple added the type:hot fix Changes fix a critical bug label Jan 29, 2024
@jdalrymple
Copy link
Owner Author

🚀 PR was released in 39.34.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Deploy canary release released This issue/pull request has been released. type:hot fix Changes fix a critical bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build files are missing in published versions
1 participant